Skip to content

Switch preset to extra-small by default#17

Merged
DebakelOrakel merged 1 commit into
masterfrom
breaking/switch-deployment-strategy
Jun 25, 2026
Merged

Switch preset to extra-small by default#17
DebakelOrakel merged 1 commit into
masterfrom
breaking/switch-deployment-strategy

Conversation

@DebakelOrakel

@DebakelOrakel DebakelOrakel commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR uses extra-small preset by default.
The deployment strategy SimpleScalable is deprecated and only available with presets legacy and none.
Every other preset uses deployment strategy Distributed

Fixes global NodeSelector not respected.
Removes unused gateway config, from switch to OSS chart.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

This PR uses extra-small preset by default.
The deployment strategy `SimpleScalable` is deprecated and only available with presets `legacy` and `none`.
Every other preset uses deployment strategy `Distributed`
@DebakelOrakel DebakelOrakel force-pushed the breaking/switch-deployment-strategy branch from 879a182 to a831d58 Compare June 24, 2026 12:56
@DebakelOrakel DebakelOrakel requested a review from a team June 25, 2026 06:51
Comment thread component/helm_values.jsonnet
Comment thread component/helm_values.jsonnet
Comment thread component/helm_values.jsonnet

@simu simu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the golden test diff

@DebakelOrakel DebakelOrakel merged commit 1ba0eb1 into master Jun 25, 2026
15 checks passed
@DebakelOrakel DebakelOrakel deleted the breaking/switch-deployment-strategy branch June 25, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants